KIALI-2034 Fixes for Create Istio Object endpoints

[lucasponce]

• Adjust the right endpoint in the k8s Api
• Parse object to validate type vs payload
• Reformat JSON object used

[lucasponce]

Tested with:

POST http://admin:admin@localhost:8000/api/namespaces/bookinfo/istio/destinationrules
Content-Type: application/json

{
  "metadata": {
    "name": "reviews"
  },
  "spec": {
    "host": "reviews",
    "subsets": [
      {
        "name": "v1",
        "labels": {
          "version": "v1"
        }
      },
      {
        "name": "v2",
        "labels": {
          "version": "v2"
        }
      },
      {
        "name": "v3",
        "labels": {
          "version": "v3"
        }
      }
    ]
  }
}

Or

POST http://admin:admin@localhost:8000/api/namespaces/bookinfo/istio/adapters/memquotas
Content-Type: application/json

{
  "metadata": {
    "name": "adapter-memquota-fake"
  },
  "spec": {
  }
}

[burmanm]

Doesn't this kinda ruin the separation? Shouldn't it be a detail of Create?

[lucasponce]

I thought that handler layer should process the input parameters and validate those are correct.
Return a BadRequest / 400 error, like a malformed or bad body.
Yeah, this is something in the middle of handlers / business layer.
Return a 404 from the business layer ? and add a IsBadRequest() after the CreateIstioConfigDetail() ?

I can do that if it's more clear.

[burmanm]

I think it would make more sense, given that we return 404 from business layer also later. Thus, the handler should probably only verify the JSON can be extracted and not care about the actual data.

[lucasponce]

Ok, will move it inside the business and also check the 400 in the returning error, that will place same logic together.

[lucasponce]

@burmanm I've sent a commit to move this logic, let me know if the PR works for you.

[rhqci]

Jenkins CI: kiali-core-pr-e2e-test #442

• 🔴 run-kiali-e2e-tests #[1054]

[lucasponce]

@hhovsepy I don't see why the e2e are failing as there is not a change on them and the logic introduced is new.
Could you take a look ? The PR is not yet finished, I need to address some comments, but the e2e failing is intriguing.

[rhqci]

Jenkins CI: kiali-core-pr-e2e-test #457

• ✔️ run-kiali-e2e-tests #[1071]

[burmanm]

Appears to work, although I would say our "DELETE" answer is incorrect - it's not JSON.

[miburman@miranda kiali]$ curl -X DELETE https://admin:admin@kiali-istio-system.192.168.1.105.nip.io/api/namespaces/bookinfo/istio/destinationrules/reviews --insecure
"Deleted"[miburman@miranda kiali]$ 
[miburman@miranda kiali]$ curl -d "@post-test.json" -X POST https://admin:admin@kiali-istio-system.192.168.1.105.nip.io/api/namespaces/bookinfo/istio/destinationrules --insecure | python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1124  100   759  100   365   7744   3724 --:--:-- --:--:-- --:--:-- 11469
{
    "adapter": null,
    "destinationRule": {
        "metadata": {
            "creationTimestamp": "2019-01-25T11:45:35Z",
            "generation": 1,
            "name": "reviews",
            "namespace": "bookinfo",
            "resourceVersion": "409174",
            "selfLink": "/apis/networking.istio.io/v1alpha3/namespaces/bookinfo/destinationrules/reviews",
            "uid": "ba6034c1-2096-11e9-8c48-28d2449dcdfa"
        },
        "spec": {
            "host": "reviews",
            "subsets": [
                {
                    "labels": {
                        "version": "v1"
                    },
                    "name": "v1"
                },
                {
                    "labels": {
                        "version": "v2"
                    },
                    "name": "v2"
                },
                {
                    "labels": {
                        "version": "v3"
                    },
                    "name": "v3"
                }
            ],
            "trafficPolicy": null
        }
    },
    "gateway": null,
    "namespace": {
        "name": "bookinfo"
    },
    "objectType": "destinationrules",
    "permissions": {
        "delete": false,
        "update": false
    },
    "policy": null,
    "quotaSpec": null,
    "quotaSpecBinding": null,
    "rule": null,
    "serviceEntry": null,
    "template": null,
    "validation": null,
    "virtualService": null
}
[miburman@miranda kiali]$ curl -d "@post-test.json" -X POST https://admin:admin@kiali-istio-system.192.168.1.105.nip.io/api/namespaces/bookinfo/istio/destinationrules --insecure | python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   440  100    75  100   365   1136   5530 --:--:-- --:--:-- --:--:--  6666
{
    "error": "destinationrules.networking.istio.io \"reviews\" already exists"
}
[miburman@miranda kiali]$