[v1.73] Graph context menu fixed + downgrade openshift-sdk to support OCP 4.12+ #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhoyos
added
test: n/a
|
Do not merge until OSSM 2.5.0 is released. |
|
OSSM 2.5 is released, so we can merge backports to v1.73 branch |
ferhoyos
force-pushed
the
downgrade-openshift-sdk-1.73
branch
from
f0b13e7
to
df06515
Compare
) * Copy of Kiali frontend source code Kiali frontend source originated from: * git ref: v1.73 * git commit: 1ac06a5ad1b2e4a04e2da057b00b4d1c96a85f93 * GitHub URL: https://github.com/kiali/kiali/tree/1ac06a5ad1b2e4a04e2da057b00b4d1c96a85f93/frontend/src Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com> * Update frontend libraries * Downgrade openshift-console libraries to support OCP 4.12+ --------- Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com>
Kiali frontend source originated from: * git ref: v1.73 * git commit: e0589b3dfac102a5299451b7d3c29ae16ac7ce85 * GitHub URL: https://github.com/kiali/kiali/tree/e0589b3dfac102a5299451b7d3c29ae16ac7ce85/frontend/src Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com>
ferhoyos
force-pushed
the
downgrade-openshift-sdk-1.73
branch
from
df06515
to
a035a31
Compare
ferhoyos
changed the title
ferhoyos
commented
Mar 27, 2024
| "bootstrap-slider-without-jquery": "10.0.0", | ||
| "cy-node-html-label": "2.0.0", | ||
| "cytoscape": "3.15.5", | ||
| "cytoscape-canvas": "3.0.1", | ||
| "cytoscape-popper": "1.0.7", | ||
| "dagre": "0.8.5", | ||
| "dagre": "0.8.2", |
There was a problem hiding this comment.
dagre library is downgraded to match with @patternfly/react-topology dagre dependency and avoid library duplications
ferhoyos
commented
Mar 27, 2024
| @@ -126,13 +125,6 @@ | |||
| "webpack-cli": "^4.9.1", | |||
| "webpack-dev-server": "^4.5.0" | |||
| }, | |||
| "resolutions": { | |||
There was a problem hiding this comment.
I have reviewed all dependency resolutions and found them to be outdated. The previous versions of these libraries no longer exist to be overridden in the yarn.lock file. I haven't yet checked the Kiali repository, but it's likely that this change can also be applied there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Backport of #261 to branch v1.73
Fixes #284 in branch v1.73
To avoid
yarn.lockconflicts I have merged both changes in one PR (backport of #261 is quite simple, no test needed).For the review, you can ignore changes in
src/kiali, they have been copied from the Kiali repository.How to test the PR
-- Node graph: Opens a new detailed graph. Check that back button works too.
-- Any other option to go to details page