Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the load settings of the Istio config list page when switching namespaces #290

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Initialize the load settings of the Istio config list page when switching namespaces #290

merged 1 commit into from
Apr 3, 2024

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Apr 2, 2024

Describe the change

Initialize the load settings of the Istio config list page when switching namespaces.

Steps to test the PR

  1. Change Kiali server config to allow only specific namespace to be accessible (avoid using the ** value).
  2. Navigate to Service Mesh -> Istio Config List.
  3. Switch to forbidden namespace and verify that the Forbidden message appears.
  4. Switch to accessible namespace and verify that the Istio Config items list is displayed.

Automation testing

Automation testing for the Istio config list page to be implemented (#289)

Issue reference

Fixes #288

@ferhoyos ferhoyos self-assigned this Apr 2, 2024
@ferhoyos ferhoyos added the test: n/a PR does not need test additions or updates label Apr 2, 2024
jshaughn
jshaughn approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@ferhoyos ferhoyos merged commit 28e768a into kiali:main Apr 3, 2024
2 checks passed
@ferhoyos ferhoyos deleted the 288-switch-forbidden-namespace branch April 3, 2024 06:54
ferhoyos added a commit to ferhoyos/openshift-servicemesh-plugin that referenced this pull request Apr 3, 2024
@ferhoyos
Initialize error on namespace switch (kiali#290)
200830c
@ferhoyos ferhoyos mentioned this pull request Apr 3, 2024
Merged
ferhoyos added a commit that referenced this pull request Apr 3, 2024
@ferhoyos
Initialize error on namespace switch (#290) (#291)
27a5965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

@josunect josunect Awaiting requested review from josunect

Assignees

@ferhoyos ferhoyos

Labels
test: n/a PR does not need test additions or updates
Projects
Kiali Sprint 24-7 | Kiali v1.86
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Istio config list page does not update when switching from a forbidden namespace to an accessible one
2 participants
@ferhoyos @jshaughn