Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.73] Avoid multiple redirection when clicking on reference links #301

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Apr 12, 2024

Describe the change

This PR avoids that OSSMC perform multiple redirections when clicking on reference links, such as a workload link related to a specific service.

Note: Found a possible issue because security information was loaded after the first initial render. Now I wait for all config and security requests before setting Kiali as loaded.

Steps to test the PR

  1. Go to the istio config list page
  2. Click on any istio item
  3. In the Service Mesh tab, click on any reference
  4. Verify that the console navigates to the desired reference page
  5. Click on the browser back button
  6. Verify that the console navigates to the previous page

Automation testing

To be included in #254

Issue reference

Fixes #300

@ferhoyos ferhoyos self-assigned this Apr 12, 2024
@ferhoyos ferhoyos added the test: n/a PR does not need test additions or updates label Apr 12, 2024
@ferhoyos ferhoyos changed the title [1.73] Avoid multiple redirection when clicking on reference links [v1.73] Avoid multiple redirection when clicking on reference links Apr 22, 2024
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ferhoyos ferhoyos merged commit 8d02a46 into kiali:v1.73 Apr 30, 2024
2 checks passed
@ferhoyos ferhoyos deleted the avoid-multiple-redirections branch April 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants