Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gateway API objects #322

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Jun 21, 2024

Describe the change

This PR includes Gateway API objects in the Istio Config list page, just like in the Kiali standalone application.

image

Bonus:

Steps to test the PR

  1. Create any Gateway API object (Gateway, HTTPRoute, etc)
  2. Navigate to the Istio Config list page
  3. Verify that the Gateway API object appears on the list with a link that redirects you to the details page of that object.

image

Automation testing

#289

Issue reference

Closes #317

@ferhoyos ferhoyos self-assigned this Jun 21, 2024
@ferhoyos ferhoyos marked this pull request as ready for review June 24, 2024 10:25
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@ferhoyos ferhoyos merged commit 93a9e28 into kiali:main Jun 26, 2024
2 checks passed
@ferhoyos ferhoyos deleted the 317-gateway-api-support branch June 26, 2024 16:07
ferhoyos added a commit to ferhoyos/openshift-servicemesh-plugin that referenced this pull request Jun 28, 2024
* Support Gateway API objects

* Fulfill kind and apiVersion values

* Change istioResources id

* Set Kind and Api Version to Istio items for specific namespaces
ferhoyos added a commit that referenced this pull request Jul 1, 2024
* Copy of Kiali frontend source code
Kiali frontend source originated from:
* git ref:    v1.86
* git commit: 6609ffd036fe2efd60e3eaccd48b3405789d05e2
* GitHub URL: https://github.com/kiali/kiali/tree/6609ffd036fe2efd60e3eaccd48b3405789d05e2/frontend/src

Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com>

* Support Gateway API objects (#322)

* Support Gateway API objects

* Fulfill kind and apiVersion values

* Change istioResources id

* Set Kind and Api Version to Istio items for specific namespaces

---------

Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support for Gateway API objects in the Istio Config list page
2 participants