Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EIA/CEA-708 Closed Captions #103

Open
kiall opened this issue Jan 3, 2017 · 15 comments
Open

Support EIA/CEA-708 Closed Captions #103

kiall opened this issue Jan 3, 2017 · 15 comments

Comments

@kiall
Copy link
Owner

kiall commented Jan 3, 2017

Block on ExoPlayer support:

google/ExoPlayer#1807

@kiall
Copy link
Owner Author

kiall commented Jan 3, 2017

Originally brought up on G+ https://plus.google.com/115557954602502982039/posts/TkZ4i7bWBRz by L.Tran

@kiall
Copy link
Owner Author

kiall commented Feb 20, 2017

This should be fixed in builds which use ExoPlayer 2.2.0+ google/ExoPlayer@18a24a1

I don't have any content to test this with (that I know of!), and there are still some issues which have been found and fixed, but aren't in a ExoPlayer release yet: google/ExoPlayer@537a3ab

I'm going to close this one out, please reopen anyone has content with EIA/CEA-708 captions and it's not working.

@kiall kiall closed this as completed Feb 20, 2017
@xaudiblex
Copy link

I just gave the update a try & there are no options for captions. However, if I use Google's network tuner implementation, it shows CC as an option & captions properly work.

@kiall
Copy link
Owner Author

kiall commented Feb 24, 2017

Thanks, will have to see if there's something else needed to make this work :(

@kiall kiall reopened this Feb 24, 2017
@kiall
Copy link
Owner Author

kiall commented Feb 24, 2017

By any chance could you record a few mins of a channel with this kind of caption for me? Details here https://github.com/kiall/android-tvheadend/wiki/Muxdump

@xaudiblex
Copy link

xaudiblex commented Feb 24, 2017 via email

@xaudiblex
Copy link

xaudiblex commented Mar 18, 2017 via email

@xaudiblex
Copy link

xaudiblex commented Mar 18, 2017 via email

@kiall
Copy link
Owner Author

kiall commented Mar 18, 2017

@xaudiblex are you sure that contains any subtitles? Neither VLC / ffmpeg show that clip as having any subtitles.. Also - it looks like the "profile=pass" piece of the URL was missed, the linked file is a Matroska / MKV file, which could be the reason the captions are missing.

Whatever URL you used, you'll need to add the profile piece to it so it gives the raw mpeg-TS data

@kiall
Copy link
Owner Author

kiall commented Mar 18, 2017

Oh. The docs don't have the profile=pass piece in it, heh. let me update them.

@kiall
Copy link
Owner Author

kiall commented Mar 18, 2017

Ah, Nevermind, it looks like you recorded from a channel, rather than from the service or mux.

Recording from a service/mux URL is always in MPEG-TS. I've updated Step 1 of the muxdump wiki to be more clear, could you have another look and try again? Thanks!

@xaudiblex
Copy link

xaudiblex commented Mar 19, 2017 via email

@kiall
Copy link
Owner Author

kiall commented Apr 5, 2017

Sorry, been travelling so haven't been near the app for a few weeks!

As near as I can see, this file still doesn't contain a EIA/CEA caption stream? Also, it's still an MKV file. I'm not sure why you're getting MKV instead of a MPEG-TS stream.

Input #0, matroska,webm, from '/home/kiall/Downloads/ATSC Sample Service Mux.ts':
  Metadata:
    title           : ATSC-T Network/599.028MHz/KDFW DT
    encoder         : Tvheadend Matroska muxer
  Duration: N/A, start: 0.000000, bitrate: N/A
    Stream #0:0(eng): Video: mpeg2video, none(progressive), 1280x720, SAR 1:1 DAR 16:9, 59.96 fps, 59.96 tbr, 1k tbn, 119.88 tbc (default)
    Stream #0:1(eng): Audio: ac3, 48000 Hz, 5.1(side), 448 kb/s (default)
    Stream #0:2(spa): Audio: ac3, 48000 Hz, stereo, 192 kb/s (default)

@kiall
Copy link
Owner Author

kiall commented Apr 5, 2017

Removing Upstream Limitation label, as ExoPlayer does seem to support this now.. I just need sample content to get it going!

@kiall
Copy link
Owner Author

kiall commented Jul 15, 2017

See #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants