Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some hands-on refinements on your boilerplate #1

Merged
merged 7 commits into from Mar 11, 2018

Conversation

dfpoon
Copy link
Contributor

@dfpoon dfpoon commented Mar 11, 2018

Thanks for your work! I have built a bot on aws lambda based on your code. However, I found your boilerplate missed some points to make it work. I have added them in this git commit. Please see if you would like to accept it.

Major updates:

  1. set_webhook.py
  2. handle on_callback_query mechanism to app.py
  3. beef up readme

@kianhean
Copy link
Owner

Wow thank you! This is a very nice update. Will write you in as a contributor. :)

@kianhean kianhean merged commit 82530de into kianhean:master Mar 11, 2018
@dfpoon
Copy link
Contributor Author

dfpoon commented Mar 11, 2018

You are welcome. Sharing knowledge and building upon other's work is the spirit of open source.

I have troubles on how to work out the Zappa deployment at the beginning. Your boilerplate has saved me a lot of time. My contribution is just a minor compliment to your initial effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants