Skip to content

Commit

Permalink
[ML] Functional tests - omit node_name in job message assertions (ela…
Browse files Browse the repository at this point in the history
…stic#111529) (elastic#111552)

This PR removes the node_name from job audit message assertions as it can vary depending on test environments, particularly in cloud.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
  • Loading branch information
kibanamachine and pheyos committed Sep 8, 2021
1 parent 03c6f2a commit 066624f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,10 @@ export default ({ getService }: FtrProviderContext) => {

expect(getBody.messages.length).to.eql(1);

expect(omit(getBody.messages[0], 'timestamp')).to.eql({
expect(omit(getBody.messages[0], ['timestamp', 'node_name'])).to.eql({
job_id: 'test_get_job_audit_messages_1',
message: 'Job created',
level: 'info',
node_name: 'node-01',
job_type: 'anomaly_detector',
cleared: true,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,16 @@ export default ({ getService }: FtrProviderContext) => {

const messagesDict = keyBy(body.messages, 'job_id');

expect(omit(messagesDict.test_get_job_audit_messages_2, 'timestamp')).to.eql({
expect(omit(messagesDict.test_get_job_audit_messages_2, ['timestamp', 'node_name'])).to.eql({
job_id: 'test_get_job_audit_messages_2',
message: 'Job created',
level: 'info',
node_name: 'node-01',
job_type: 'anomaly_detector',
});
expect(omit(messagesDict.test_get_job_audit_messages_1, 'timestamp')).to.eql({
expect(omit(messagesDict.test_get_job_audit_messages_1, ['timestamp', 'node_name'])).to.eql({
job_id: 'test_get_job_audit_messages_1',
message: 'Job created',
level: 'info',
node_name: 'node-01',
job_type: 'anomaly_detector',
});
expect(body.notificationIndices).to.eql(['.ml-notifications-000002']);
Expand All @@ -67,11 +65,10 @@ export default ({ getService }: FtrProviderContext) => {
.expect(200);

expect(body.messages.length).to.eql(1);
expect(omit(body.messages[0], 'timestamp')).to.eql({
expect(omit(body.messages[0], ['timestamp', 'node_name'])).to.eql({
job_id: 'test_get_job_audit_messages_1',
message: 'Job created',
level: 'info',
node_name: 'node-01',
job_type: 'anomaly_detector',
});
expect(body.notificationIndices).to.eql(['.ml-notifications-000002']);
Expand All @@ -85,11 +82,10 @@ export default ({ getService }: FtrProviderContext) => {
.expect(200);

expect(body.messages.length).to.eql(1);
expect(omit(body.messages[0], 'timestamp')).to.eql({
expect(omit(body.messages[0], ['timestamp', 'node_name'])).to.eql({
job_id: 'test_get_job_audit_messages_1',
message: 'Job created',
level: 'info',
node_name: 'node-01',
job_type: 'anomaly_detector',
});
expect(body.notificationIndices).to.eql(['.ml-notifications-000002']);
Expand Down

0 comments on commit 066624f

Please sign in to comment.