[Security Solution] Fixes bulk close alerts from exception flyout typ…

…e bug (elastic#150765)
kibanamachine · Feb 9, 2023 · 216fb3a · 216fb3a
1 parent 20a9a01
commit 216fb3a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.../plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.test.tsx b/.../plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.test.tsx
@@ -384,6 +384,16 @@ describe('Exception helpers', () => {
       const result = prepareExceptionItemsForBulkClose(payload);
       expect(result).toEqual(expected);
     });
+
+    test("should strip out any comments in the exceptions for bulk close'", () => {
+      const exceptionItemWithComment = {
+        ...getExceptionListItemSchemaMock(),
+        comments: getCommentsArrayMock(),
+      };
+      const payload = [exceptionItemWithComment];
+      const result = prepareExceptionItemsForBulkClose(payload);
+      expect(result).toEqual([getExceptionListItemSchemaMock()]);
+    });
   });
 
   describe('#lowercaseHashValues', () => {

diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
@@ -154,9 +154,10 @@ export const prepareExceptionItemsForBulkClose = (
       return {
         ...item,
         entries: newEntries,
+        comments: [], // Strips out unneeded comments attribute for bulk close as they are not needed and are throwing type errors
       };
     } else {
-      return item;
+      return { ...item, comments: [] };
     }
   });
 };