Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fanout support via SNS+SQS #6

Merged
merged 12 commits into from
Jun 28, 2023
Merged

Implement fanout support via SNS+SQS #6

merged 12 commits into from
Jun 28, 2023

Conversation

kibertoad
Copy link
Owner

This allow to have publish/subscribe notifications for multiple consumers.

@kibertoad kibertoad requested a review from dariacm June 27, 2023 22:07
Copy link
Collaborator

@dariacm dariacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I get it right that we are using SQS queues to subscribe to SNS topics? I don't have lots of experience with SNS/SQS, so maybe my comments are wrong. Feel free to dismiss in that case! 🙇🏻‍♀️

But overall looks good to me 💯

packages/sns/lib/sns/AbstractSnsService.ts Outdated Show resolved Hide resolved
packages/sns/lib/sns/AbstractSnsService.ts Show resolved Hide resolved
packages/sns/lib/sns/snsMessageDeserializer.ts Outdated Show resolved Hide resolved
kibertoad and others added 3 commits June 28, 2023 11:41
Co-authored-by: Daria Carlotta Maino <62015076+dariacm@users.noreply.github.com>
@kibertoad kibertoad merged commit d5c146e into main Jun 28, 2023
4 checks passed
@kibertoad kibertoad deleted the feat/sns branch June 28, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants