Question: Is it possible to target a specific job to stop rather than to stop the whole scheduler?

[mattiaslvv]

const { ToadScheduler, SimpleIntervalJob, AsyncTask } = require('toad-scheduler')

const scheduler = new ToadScheduler()

const task = new AsyncTask(
    'simple task', 
    () => { return db.pollForSomeData().then((result) => { /* continue the promise chain */ }) },
    (err: Error) => { /* handle error here */ }
)
const job = new SimpleIntervalJob({ seconds: 20, }, task)

scheduler.addSimpleIntervalJob(job)

// when stopping your app
scheduler.stop()

New to toad-scheduler. Is there a way to target a specific job, for termination? scheduler.stop() seems to end all running jobs.

[kibertoad]

@jenseneducation-mattias-von-vogelsang There is a .stop() method on job itself, would that suffice?

[mattiaslvv]

Sounds promising. However, ideally I want to be able to terminate the job from the tasks error handler. For example via scheduler.stop('job1').

[kibertoad]

E. g.:

const { ToadScheduler, SimpleIntervalJob, AsyncTask } = require('toad-scheduler')

const scheduler = new ToadScheduler()

const task = new AsyncTask(
    'simple task', 
    () => { return db.pollForSomeData().then((result) => { /* continue the promise chain */ }) },
    (err: Error) => { /* handle error here */ }
)
const job = new SimpleIntervalJob({ seconds: 20, }, task)

scheduler.addSimpleIntervalJob(job)

// stopping specific job
job.stop()

It is not possible to stop job from the task, by design, because task is a child of job, and as such is not aware of its existence.
Your suggested option seems to be the way to go, I'll add support for that.

[mattiaslvv]

Thank you kindly for your example. Unfortunately It would not help me in my use case.

I would like that very much, it would fit my specific use case perfectly. Thank you!

[kibertoad]

will release a new version later tonight

[mattiaslvv]

Thank you kindly for your implementation. I'll try it out tomorrow. Closing this.

[kibertoad]

@jenseneducation-mattias-von-vogelsang Just published 1.2.0 with the stopping/starting functionality.

[mattiaslvv]

@kibertoad Awesome. I just got home, I'll implement it in my code.

[mattiaslvv]

@kibertoad I tried to push a branch for a PR on fastify-schedule to bump toad-scheduler to 1.2 but got a 403. Could you bump it or give me temporary write access to push the branch?

[kibertoad]

@jenseneducation-mattias-von-vogelsang Isn't usual GitHub flow to fork a repository and then create a PR from that fork? Also since fastify-schedule doesn't come with package-lock, I believe updating locally should be sufficient.

[mattiaslvv]

Ah! My bad, I'm new to "contributing" to open source.
I'll do it locally. Thanks!