add ntfy notifier #141
Merged
add ntfy notifier #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdemin
approved these changes
Jan 5, 2024
kibitzr/notifier/ntfy.py
Outdated
| ) | ||
| logger.debug(response.text) | ||
| response.raise_for_status() | ||
| return response |
There was a problem hiding this comment.
Should it return response? I thought notifiers' results are ignored.
There was a problem hiding this comment.
I copied the code from Gotify, which appears to have copied from Webhook. I think you're right, though, that the results are ignored. I'll remove it from here. Want me to remove it from the others as well?
|
Thank you! The PR LGTM with a minor comment above. I'll try to merge/release it later today. |
|
Released in 7.0.6, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sending notifications to a ntfy server (similar to Gotify). See https://ntfy.sh