-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint field in configuration page #3
Add endpoint field in configuration page #3
Conversation
(cherry picked from commit f00b4c6)
'sylius.form.gateway_configuration.payzen.endpoint.choices.default' => null, | ||
'sylius.form.gateway_configuration.payzen.endpoint.choices.clic_and_pay' => Api::ENDPOINT_CLICANDPAY, | ||
'sylius.form.gateway_configuration.payzen.endpoint.choices.scellius' => Api::ENDPOINT_SCELLIUS, | ||
'sylius.form.gateway_configuration.payzen.endpoint.choices.systempay' => Api::ENDPOINT_SYSTEMPAY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this list is missing SogeCommerce's URL: https://sogecommerce.societegenerale.eu/vads-payment/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunaly, SogeCommerce is not yet implemented in ekyna/PayzenPayum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for this PR to be merged and released : ekyna/PayumPayzen#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say go to merge this since ekyna has made a new release
About the build error, I didn't spent much time to investigate on it within my other Sylius plugin repositories, but it's something we don't have to care here, only Sylius 1.10 with Symfony 4.4 is failing. |
@gplanchat Do you want resolve the CI issues ? Or wait an another PR ? |
No need to fix the build @FlorentinGarnier, Sylius 1.10 will be soon deprecated so we can only focus on Sylius > 1.11 |
LGTM in this case ;) |
For the record, I found what was the issue with the missing service, it appears that To fix it I alter a little bit the protected function build(ContainerBuilder $container)
{
// Fix APIPlatform issue during console initialisation
// Service "api_platform.error_listener": Parent definition "exception_listener" does not exist.
$sfVersion = sprintf('%d.%d', BaseKernel::MAJOR_VERSION, BaseKernel::MINOR_VERSION);
if ('4.4' !== $sfVersion) {
return;
}
if (false === $container->hasDefinition('exception_listener')) {
$container->setAlias('exception_listener', new Alias('console.error_listener'));
}
} It will add an alias if the service is missing and only for Symfony 4.4. |
Add a list of endpoint in config page