Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix where redirecting URLs may not include schemes or hosts #24

Closed
wants to merge 1 commit into from

Conversation

belphegor-belbel
Copy link

Section 7.1.2 in RFC-7231 defines a "Location:" header for specifying the destination URL,
it may not contain schemes or hosts as shown in the example ("Location: /People.html#tim").

https://www.rfc-editor.org/rfc/rfc7231

However in NSISdl current implementation, the Location header's content is passed to the
connect() method as-is, so the first part up to "/" is interpreted as the host name,
so it fails.

This patch makes it possible to regenerate the destination URL from the original one.

@sredna
Copy link
Collaborator

sredna commented Aug 2, 2023

  • Hardcodes buffer size of 1024
  • Does not support //host/path relative URLs?

@sredna sredna closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants