Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change navigation policy to emphasize C-g and support hiding #6

Closed
kickingvegas opened this issue Jun 27, 2024 · 1 comment · Fixed by #7
Closed

Change navigation policy to emphasize C-g and support hiding #6

kickingvegas opened this issue Jun 27, 2024 · 1 comment · Fixed by #7
Assignees
@kickingvegas
Labels
enhancement New feature or request ux change

Comments

@kickingvegas
Copy link
Owner

kickingvegas commented Jun 27, 2024 •
edited
Loading

Current navigation policy prioritizes using the binding C-q to exit the menu hierarchy completely. For only a single menu this is functional but mildly surprising as the binding C-g is more commonly used/expected.

Proposal

Change navigation policy as follows:

Single Menu

Binding Command Label Notes
C-g transient-quit-one Dismiss As there is no parent menu, there is no “Back” to go to, so the label “Dismiss” is used.

Menu Level > 1

Binding Command Label Notes
C-g transient-quit-one ‹Back This is effectively a “Back” command.
C-q transient-quit-all Dismiss This command shall completely exit out of the workflow.

Hiding

This adds the user preference to omit display of either C-g or C-q as they are default bindings in Transient menus. This behavior is used by Magit.

Proposed variable name: casual-lib-hide-navigation with default value of nil.
@kickingvegas kickingvegas added the enhancement New feature or request label Jun 27, 2024
@kickingvegas kickingvegas self-assigned this Jun 27, 2024
This was referenced Jun 27, 2024
Closed
Closed
Closed
Closed
Closed
@kickingvegas kickingvegas changed the title Change navigation policy to emphasize C-g Change navigation policy to emphasize C-g and support hiding Jun 27, 2024
kickingvegas added a commit that referenced this issue Jun 28, 2024
@kickingvegas
Change navigation policy and support hiding
92ea4e9 
- Implement navigation policy and hiding changes as described in #6.
- Add Makefile target "status" for git status.
- Fix documentation error for Transit with Transient.
kickingvegas added a commit that referenced this issue Jun 28, 2024
@kickingvegas
Change navigation policy and support hiding
92e22f4 
- Implement navigation policy and hiding changes as described in #6.
- Add Makefile target "status" for git status.
- Fix documentation error for Transit with Transient.
- Added MELPA badge.
@kickingvegas kickingvegas mentioned this issue Jun 28, 2024
Merged
@kickingvegas kickingvegas linked a pull request Jun 28, 2024 that will close this issue
Change navigation policy and support hiding #7
Merged
kickingvegas added a commit that referenced this issue Jun 28, 2024
@kickingvegas
Change navigation policy and support hiding
3b387f8 
- Implement navigation policy and hiding changes as described in #6.
- Add Makefile target "status" for git status.
- Fix documentation error for Transit with Transient.
- Added MELPA badge.
- Adds dependency on Transient 0.6.0.
@kickingvegas kickingvegas mentioned this issue Jun 28, 2024
Merged
@kickingvegas
Copy link
Owner Author

Released this feature today. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kickingvegas kickingvegas

Labels
enhancement New feature or request ux change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change navigation policy and support hiding kickingvegas/casual-lib
1 participant
@kickingvegas