cleanup errored backing network call (#1945)

kickstarter · Feb 7, 2024 · ce5e17f · ce5e17f
1 parent dbc59a7
commit ce5e17f
Showing 1 changed file with 12 additions and 21 deletions.
diff --git a/app/src/main/java/com/kickstarter/services/KSApolloClientV2.kt b/app/src/main/java/com/kickstarter/services/KSApolloClientV2.kt
@@ -1304,28 +1304,19 @@ class KSApolloClientV2(val service: ApolloClient) : ApolloClientTypeV2 {
                         if (response.hasErrors()) {
                             ps.onError(Exception(response.errors?.first()?.message))
                         } else {
-                            Observable.just(response.data)
-                                .map { cards -> cards?.me()?.backings()?.nodes() }
-                                .map { list ->
-                                    val erroredBackings = list?.asSequence()?.map {
-                                        val project = ErroredBacking.Project.builder()
-                                            .finalCollectionDate(
-                                                it.project()?.finalCollectionDate()
-                                            )
-                                            .name(it.project()?.name())
-                                            .slug(it.project()?.slug())
-                                            .build()
-                                        ErroredBacking.builder()
-                                            .project(project)
-                                            .build()
-                                    }
-                                    erroredBackings?.toList() ?: listOf()
-                                }
-                                .subscribe {
-                                    ps.onNext(it)
-                                    ps.onComplete()
-                                }.dispose()
+                            val erroredBackings = response.data?.me()?.backings()?.nodes()?.map {
+                                val project = ErroredBacking.Project.builder()
+                                    .finalCollectionDate(it.project()?.finalCollectionDate())
+                                    .name(it.project()?.name())
+                                    .slug(it.project()?.slug())
+                                    .build()
+                                return@map ErroredBacking.builder()
+                                    .project(project)
+                                    .build()
+                            } ?: listOf()
+                            ps.onNext(erroredBackings)
                         }
+                        ps.onComplete()
                     }
                 })
             return@defer ps