NTV-395: UI – Out of place image captions (#1542)

kickstarter · Feb 15, 2022 · cf96299 · cf96299
1 parent 2a47258
commit cf96299
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/src/main/java/com/kickstarter/ui/viewholders/projectcampaign/ImageElementViewHolder.kt b/app/src/main/java/com/kickstarter/ui/viewholders/projectcampaign/ImageElementViewHolder.kt
@@ -10,7 +10,6 @@ import com.kickstarter.ui.views.OnImageWithCaptionClickedListener
 class ImageElementViewHolder(
     val binding: ViewElementImageFromHtmlBinding
 ) : KSViewHolder(binding.root) {
-    // TODO: attach ViewModel if necessary
     private val imageView = binding.imageView
 
     private fun configure(element: ImageViewElement) {
@@ -33,7 +32,9 @@ class ImageElementViewHolder(
 
     override fun bindData(data: Any?) {
         (data as? ImageViewElement).apply {
-            this?.let { configure(it) }
+            this?.let {
+                configure(it)
+            }
         }
     }
 }
diff --git a/app/src/main/java/com/kickstarter/ui/views/ImageWithCaptionView.kt b/app/src/main/java/com/kickstarter/ui/views/ImageWithCaptionView.kt
@@ -60,7 +60,7 @@ class ImageWithCaptionView @JvmOverloads constructor(
                     isUnderlineText = true
                 )
             }
-        }
+        } else binding.imageCaptionTextView.isVisible = false
     }
 
     fun setLinkOnImage(href: String?) {