Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1654:Detect user validated flow #1032

Merged
merged 14 commits into from
Nov 9, 2020

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Nov 6, 2020

📲 What

  • Analice the response from the login endpoint to check if a user is validatedEmail or not.
  • In case feature flag on the login flow / create account flow will not continue, next steps will be presenting Interstitial screen.
  • In case feature flag off the login flow / create account flow will continue as it is now.

🛠 How

  • Added field isEmailVerified to the User dataModel
  • Moved some previously existing UI extensions to a package ui.extensions
  • Added logic on LoginViewModel
  • Added logic on SignUpViewModel

👀 See

  • No UI updates in this PR, bet here a screenshoot from a successful networking response, with isEmailVerified field true :)

Screen Shot 2020-11-03 at 10 49 47 AM

| | |

📋 QA

UAT Login flow:
Try login flow from DiscoveryActivity, UpdatesActivity, PledgeFragment

  • Log in with feature flag on and user with email validated -> behaviour as expected now
  • Log in with feature flag on and user without email validated -> You cannot go over the logIn screen (in the future you will be presented with the Interstitial Screen)
  • Log in with feature flag on and user without email validated -> try to log in, kill the app, put the app in background or kill it, open it again, you should not be logged in
  • Log in with feature flag off and user without email validated -> try to log in, kill the app, put the app in background or kill it, open it again, you should be logged in with the invalidated user
  • Log in with feature flag off and user with email validated -> behaviour as expected now

UAT Create Account flow:

  • Create Account in with feature flag off -> behaviour as expected now
  • Create Account in with feature flag on -> You cannot go over the Creation Account Screen (in the future you will be presented with the Interstitial Screen)

Story 📖

NT-1638

@Arkariang Arkariang marked this pull request as ready for review November 6, 2020 01:29
@leighdouglas
Copy link
Contributor

LGTM! 👍

@@ -73,6 +74,7 @@
public abstract Builder happeningNewsletter(Boolean __);
public abstract Builder id(long __);
public abstract Builder isAdmin(Boolean __);
public abstract Builder isEmailVerified(Boolean __);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - what are the underscores (Boolean __) supposed to be representative of?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__ is substituting a parameter name

@Arkariang Arkariang merged commit 5ba8e2a into master Nov 9, 2020
@Arkariang Arkariang deleted the imartin/NT-1654-detect-validated-flow branch November 9, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants