-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NT-1654:Detect user validated flow #1032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtensions to com.kickstarter.ui.extensions - Remove EditTextExtension.kt because there is al already existing one EditTextExt.kt added in that file the EditText.setTextAndSelection method
- Created UserExtension
…tin/NT-1654-detect-user-validated
- Error is optional
LGTM! 👍 |
leighdouglas
approved these changes
Nov 9, 2020
@@ -73,6 +74,7 @@ | |||
public abstract Builder happeningNewsletter(Boolean __); | |||
public abstract Builder id(long __); | |||
public abstract Builder isAdmin(Boolean __); | |||
public abstract Builder isEmailVerified(Boolean __); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - what are the underscores (Boolean __)
supposed to be representative of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__ is substituting a parameter name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🛠 How
isEmailVerified
to the User dataModelui.extensions
👀 See
| | |
📋 QA
UAT Login flow:
Try login flow from DiscoveryActivity, UpdatesActivity, PledgeFragment
UAT Create Account flow:
Story 📖
NT-1638