Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NT-1609: Verify email endpoint v1 #1050

Merged
merged 10 commits into from
Dec 7, 2020
Merged

NT-1609: Verify email endpoint v1 #1050

merged 10 commits into from
Dec 7, 2020

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Dec 3, 2020 •
edited
Loading

📲 What

  • Request to new endpoint in V1 to verify Email
  • Show response message on a Success/Error snackbar on discovery
  • Moved UriUtils.kt to a Uri kotlin extension

👀 See

  • Expired Email Error
    error_expired

  • Success Verification
    success_verify

  • Not Logged error
    not_logged_error

  • Networking Responses

Verify_Network_Response

| | |

📋 QA

  • Open valid verification email
  • Open email verification without user logged in the app
  • Open expired email or an used one

Story 📖

NT-1609

@Arkariang Arkariang marked this pull request as ready for review December 3, 2020 19:12
leighdouglas
leighdouglas approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! 🎉

@Arkariang Arkariang merged commit 8ca325c into master Dec 7, 2020
@Arkariang Arkariang deleted the imartin/NT-1609-verify-email-endpoint-v1 branch December 7, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@jgsamudio jgsamudio Awaiting requested review from jgsamudio

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkariang @leighdouglas