NT-1738: Android Segment Refactor: Create TestApplicationModule #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one used un production code - use ApplicationProvider.getApplicationContext() instead of the deprecated this.application = (TestKSApplication) in test Application - migrated KSRoboelectricTestCase to kotlin - Protect the inicialization of multiple libraries/lifecycles for not being triggered on Testing
- add again fix date
…ne.forID("EST") as valid timezoneid
Arkariang
commented
Jan 25, 2021
| @@ -154,6 +156,8 @@ public void testProjectsForBottomSheet_WithManyProjects() { | |||
|
|
|||
| @Test | |||
| public void testProjectSwitcherProjectClickOutput() { | |||
| DateTimeUtils.setCurrentMillisFixed(new DateTime().getMillis()); | |||
There was a problem hiding this comment.
👀 This is needed for the test to keep working, it was done before on KSRobolectricTestCase.java:51 it has been isolated just for the concrete test.
| val lakeTrackingClient = lakeTrackingClient(mockCurrentConfig, experimentsClientType) | ||
|
|
||
| val component = DaggerApplicationComponent.builder() | ||
| .applicationModule(TestApplicationModule(application())) |
leighdouglas
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
ApplicationProviderinstead of deprecatedRuntimeEnvironment.application;KSApplication.javawhen running unit tests.2.9.3is not the newest one, but the latest one we can use without changing any test.🤔 Why
The
ApplicationModulewas used on RobolectricTestCase for populating the environment object, instanciating all the third party libraries, later on that environment object was reloaded with all the mock clients. Avoid that first initialization by using the newTestApplicaionModule📋 QA
Story 📖
NT-1738: Create TestApplication Module