Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1747: Identify users on segment #1081

Merged
merged 6 commits into from
Feb 3, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Feb 2, 2021

📲 What

  • Every time a user logs in or sign up we need to identify that user on segment

🤔 Why

  • Generation of Funnels in Segment requires to Identify Users

🛠 How

  • We listen to the currentUser observable on the base Trackingclient and call identify method.

👀 See

- Debug Logcat line for identify call
Screen Shot 2021-02-02 at 9 02 29 AM

- Android staging source
Screen Shot 2021-02-02 at 8 57 36 AM

| | |

📋 QA

  • Check on the android staging source that and identify call is registered when you log in in the app
  • Check on the android staging source that and identify call is registered when you log in with an user with tfa challenge in the app
  • Check on the android staging source that and identify call is registered when sign up in in the app
  • Check on the android staging source that and identify call is registered when sign up with facebook in in the app
  • Check no duplicated calls in place for the same user

Story 📖

NT-1747: Identify users in segment

@Arkariang Arkariang changed the title Imartin/nt 1747 identify users on segment NT-1747: Identify users on segment Feb 2, 2021
@Arkariang Arkariang marked this pull request as ready for review February 2, 2021 17:04
* - Small refactor
* - Change nomenclature for  trackingData(eventName: String, newProperties: Map<String, Any?>) it returns void now.
@Arkariang Arkariang merged commit 687de2e into master Feb 3, 2021
@Arkariang Arkariang deleted the imartin/NT-1747-identify-users-on-segment branch February 3, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants