Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-221: Create event for Rewards Carousel viewed #1113

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

leighdouglas
Copy link
Contributor

馃摬 What

  • Added track event for the rewards carousel screen that fires when the RewardsFragmentViewModel is loaded.

馃 Why

Segment Integration.

馃洜 How

  • Created a new function to our AnalyticsEvents class that handles sending the event name and properties to the client.
  • Added this function to our RewardsFragmentViewModel when this vm is initialized.

馃憖 See

This is the screen that triggers the event:
Screenshot_1613763673

馃搵 QA

  • Select any project
  • Tap "Back this project"
  • This should open the rewards carousel
  • Segment (Page Viewed) should appear in the segment dashboard. There is no datalake event for this analytic event.
  • Tapping "Page Viewed" in segment should show the list of properties sent with this event.

Screen Shot 2021-02-19 at 2 44 01 PM

Screen Shot 2021-02-19 at 2 44 06 PM

Story 馃摉

EP-221: Android: Page Viewed (rewards)

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@leighdouglas leighdouglas merged commit df42b5c into master Feb 23, 2021
@leighdouglas leighdouglas deleted the leigh/ep-222-reward-page-viewed branch February 23, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants