EP-163: Create properties checkout #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighdouglas
approved these changes
Mar 8, 2021
| @@ -0,0 +1,46 @@ | |||
| @file:JvmName("PledgeDataExt") | |||
There was a problem hiding this comment.
nit: I don't think we need this annotation as the compiler is already generating this java class with this name under the hood. Might be good to keep it though for consistency/readability.
| * | ||
| * @return Double | ||
| */ | ||
| fun CheckoutData.bonus() = this.bonusAmount()?.let { it } ?: 0.0 |
There was a problem hiding this comment.
nit: the let call can be removed
| @@ -4,13 +4,14 @@ import com.kickstarter.libs.RefTag | |||
| import com.kickstarter.libs.utils.RewardUtils.isItemized | |||
| import com.kickstarter.libs.utils.RewardUtils.isShippable | |||
| import com.kickstarter.libs.utils.RewardUtils.isTimeLimitedEnd | |||
| import com.kickstarter.libs.utils.extensions.totalAmount | |||
| import com.kickstarter.libs.utils.extensions.* | |||
There was a problem hiding this comment.
nit: remove wild card import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
Added properties:
馃洜 How
馃憖 See
| | |
馃搵 QA
Manage your pledgescreenStory 馃摉
EP-163