Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-257: Create event for Project Card Clicked #1149

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

leighdouglas
Copy link
Contributor

📲 What

  • Added a track event that fires when project cards are clicked.

🤔 Why

Segment integration.

🛠 How

  • Created a new function to our AnalyticsEvents class that handles sending the event name and properties to the client.
  • Added this function to the DiscoveryFragmentViewModel, ProfileViewModel, SearchViewModel, and ActivityFeedViewModel that fires when the project card clicked stream has an emission.

👀 See

Tapping a project card on any of these screens will fire a card clicked event
Screenshot_1615307558 Screenshot_1615307565 Screenshot_1615307575 Screenshot_1615307589

📋 QA

Discover:

  • Open the app
  • Tap on a project on the discover/explore feed
  • Segment should log an event named "Card Clicked" with the context_page = explore and context_type = project

Screen Shot 2021-03-09 at 11 41 05 AM

Activity Feed:

  • Open the app
  • Tap on the overflow menu in the top left corner of the screen
  • Select "Activity"
  • Tap on a project
  • Segment should log an event named "Card Clicked" with the context_page = activity_feed and context_type = project

Screen Shot 2021-03-09 at 11 41 43 AM

Profile:

  • Open the app
  • Tap on the overflow menu in the top left corner of the screen
  • Select "Profile"
  • Tap on a project
  • Segment should log an event named "Card Clicked" with the context_page = profile and context_type = project

Screen Shot 2021-03-09 at 11 41 30 AM

Search:

  • Open the app
  • Tap on the search icon in the top left corner of the screen
  • Type in a search word
  • After results load, tap on a project
  • Segment should log an event named "Card Clicked" with the context_page = search and context_type = project

Screen Shot 2021-03-09 at 11 41 16 AM

Story 📖

EP-257: Card Clicked (Project)

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! as soon as the failing test are fixed is ok to go

@leighdouglas leighdouglas force-pushed the leigh/ep-257-project-card-cta branch from ee43f0d to 8fbdb8d Compare March 9, 2021 23:02
@leighdouglas leighdouglas merged commit c8f4b67 into master Mar 9, 2021
@leighdouglas leighdouglas deleted the leigh/ep-257-project-card-cta branch March 9, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants