Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1807:ViewUtils.java crashes #1150

Merged
merged 13 commits into from
Mar 10, 2021
Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 9, 2021

📲 What

Create View Extension and use View-binding in BackingFragment

🤔 Why

Handling crash for BackingFragment due to kotlinx.android.synthetic
image

🛠 How

Create View Extension and use View-binding in BackingFragment , so at any point null pointer exception handled

👀 See

device-2021-03-09-210521.mp4
Before 🐛 After 🦋

📋 QA

Check backed projects fragment user profile -> projects -> mange back

Story 📖

https://kickstarter.atlassian.net/browse/NT-1807

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark on ViewUtils.java the methods equivalent to this extension with the @deprecated annotation?
Screen Shot 2021-03-09 at 1 46 11 PM

@Arkariang Arkariang merged commit 4e82b7a into master Mar 10, 2021
@Arkariang Arkariang deleted the hadia/BackingFragment_ViewBinding branch March 10, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants