Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1756: Backing fragment crashes #1151

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Mar 10, 2021

馃摬 What

  • Even though when we parse the response from Graph the BackingObject created should have been initialized properly, see
    We've been seeing crashes related with nullability issues, an wrong threads trying to Update the UI, none of it was reproduced locally, if you need more details go to Firebase Dashboard and look for all the crashes related to BackingFragment

馃 Why

Screen Shot 2021-03-09 at 3 03 04 PM
Screen Shot 2021-03-09 at 3 02 41 PM
Screen Shot 2021-03-09 at 3 02 30 PM
Screen Shot 2021-03-09 at 3 01 31 PM
Screen Shot 2021-03-09 at 3 01 56 PM
Screen Shot 2021-03-09 at 3 02 19 PM

馃洜 How

  • Make sure no value from the ones above showed on the screenshoots is emited being null from the ViewModel to the Fragment

馃憖 See

BackingFragment.mp4

| | |

馃搵 QA

  • Go to your profile and take a look into several of your projects already backed, the older the better
  • Got to your messages, select some message and hit the "View Pledge" Button

Story 馃摉

NT-1756

@Arkariang Arkariang changed the title Imartin/nt 1756 backing fragment crash NT-1756: Backing fragment crashes Mar 10, 2021
@Arkariang Arkariang marked this pull request as ready for review March 10, 2021 00:46
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great

@Arkariang Arkariang merged commit 985ceaf into master Mar 10, 2021
@Arkariang Arkariang deleted the imartin/NT-1756-backing-fragment-crash branch March 10, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants