EP-261/Android: Video Playback Started #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/kickstarter/libs/AnalyticEvents.kt # app/src/main/java/com/kickstarter/libs/utils/EventContextValues.kt # app/src/main/java/com/kickstarter/libs/utils/EventName.kt
Arkariang
reviewed
Mar 18, 2021
| @@ -0,0 +1,65 @@ | |||
| package com.kickstarter.viewmodels | |||
There was a problem hiding this comment.
馃コ more migrations to Kotlin! 馃憦
Arkariang
reviewed
Mar 18, 2021
| @@ -475,6 +475,31 @@ class LakeTest : KSRobolectricTestCase() { | |||
| this.lakeTest.assertValues("Project Page Pledge Button Clicked") | |||
| } | |||
|
|
|||
| @Test | |||
| fun testVideoProperties() { | |||
There was a problem hiding this comment.
This is great @hadia is perfect! just a small thing, can you move this test from LakeTest to SegmentTest or duplicate it on SegmentTest?, Lake client will be deleted some time in the near future alongside with the tests for it, so no real need unless some test fails on keep it updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
add Video Playback Started segment event
馃 Why
A user clicks the play button on the main video on a project page
馃洜 How
Add video Properties
Add Event Handler in Video ViewModel
Update project property "Launched_at" and Deadline to time stamp to solve violations
Add test
馃憖 See
馃搵 QA
open Project and click the video Play button
Story 馃摉
https://kickstarter.atlassian.net/browse/EP-261