Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-350/Android: Page Viewed (activity_feed) #1178

Merged
merged 14 commits into from
Mar 24, 2021
Merged

EP-350/Android: Page Viewed (activity_feed) #1178

merged 14 commits into from
Mar 24, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 23, 2021

📲 What

Added the activity_feed as Page Viewed event

🤔 Why

Send segment event for activity_feed loads on the Activity Feed Activity

🛠 How

Create trackActivityFeedPageViewed and call it
image
image
Screen Shot 2021-03-23 at 8 24 40 PM
Screen Shot 2021-03-23 at 8 24 55 PM

👀 See

image

📋 QA

Open activity feed screen for login user from the side menu and check segment dashboard

Story 📖

https://kickstarter.atlassian.net/browse/EP-350

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

# Conflicts:
#	app/src/test/java/com/kickstarter/libs/SegmentTest.kt
@hadia hadia merged commit 1cc58fc into master Mar 24, 2021
@hadia hadia deleted the hadia/activity_feed branch March 24, 2021 11:53
@leighdouglas
Copy link
Contributor

Thanks for adding the CtaContext and PageContext test assertions :) super helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants