Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-451: Page Viewed (sign_up) Unit Test #1196

Merged
merged 8 commits into from
Apr 8, 2021

Conversation

sunday-okpoluaefe
Copy link
Contributor

📲 What

Android: Page Viewed (sign_up) Unit Test

🤔 Why

Unit for Test for Context Properties, Segment Properties, Session Properties, User Properties

🛠 How

 @Test
    fun testSignUpPageViewed_Properties() {

        val client = client(null)
        client.eventNames.subscribe(this.segmentTrack)
        client.eventProperties.subscribe(this.propertiesTest)

        val segment = AnalyticEvents(listOf(client))
        segment.trackSignUpPageViewed()

        assertSessionProperties(null)
        assertContextProperties()

        val properties = this.propertiesTest.value
        assertNull(properties["user_uid"])
        assertEquals(EventContextValues.ContextPageName.SIGN_UP.contextName, properties[CONTEXT_PAGE.contextName])

        this.segmentTrack.assertValue(EventName.PAGE_VIEWED.eventName)
    }

👀 See

Trello, screenshots, external resources?

Before 🐛 After 🦋

📋 QA

Instructions for anyone to be able to QA this work.

Story 📖

https://kickstarter.atlassian.net/browse/EP-451

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@sunday-okpoluaefe sunday-okpoluaefe merged commit 408935d into master Apr 8, 2021
@sunday-okpoluaefe sunday-okpoluaefe deleted the sunday/EP-335-sign-up-page-viewed branch April 8, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants