Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NT-1830: Braze basic push notification integration #1199

Merged
merged 17 commits into from
Apr 9, 2021
Merged

NT-1830: Braze basic push notification integration #1199

merged 17 commits into from
Apr 9, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Apr 8, 2021 •
edited
Loading

📲 What

  • We are now able to get Push notifications from Braze

🛠 How

  • See also this other PR necessary for configuration Braze Integration
  • BrazeClient class added with the necessary configuration setup
  • RemotePushClientType added to the Dagger component
  • MessageService will interact with BrazeClient via RemotePushClientType interface
  • DeviceRegister service will interact with BrazeClient via RemotePushClientType interface
  • Added Tests for the new client

👀 See

BrazeNotification.mp4

| | |

📋 QA

Story 📖

NT-1830

@Arkariang
- Braze integration for push notifications
271679b
@Arkariang
- Avoid any call related to deepllinking for now
f7f9259
@Arkariang
- manifest service
e0507be
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into imar…
e2f4bf0 
…tin/braze-integration-pushNotifications

# Conflicts:
#	app/build.gradle
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into imar…
7e6cb17 
…tin/braze-integration-pushNotifications
@Arkariang
- We do get Notifications now
95224fb
@Arkariang
- Created BrazeClient wrapper, we do receive basic push notifications
ea79703
@Arkariang
- Allow staging deeplinks
d3dbe40
@Arkariang
Fixed linters
ebb880d
@Arkariang
- firebase external release sender Id
b817977
@Arkariang
- RemotePushClienType
e57e832
@Arkariang
- Braze basic integration for Push notifications
ac7d93a
@Arkariang
- Added tests for Braze client
cd5c262
@Arkariang
Merge branch 'master' into imartin/NT-1830-braze-push-notifications-i…
a0493a9 
…ntegration
@Arkariang
- Coments
880493e
@Arkariang
Merge branch 'imartin/NT-1830-braze-push-notifications-integration' o…
3a4220d 
…f github.com:kickstarter/android-oss into imartin/NT-1830-braze-push-notifications-integration
@Arkariang Arkariang marked this pull request as ready for review April 8, 2021 21:07
@leighdouglas leighdouglas self-assigned this Apr 9, 2021
leighdouglas
leighdouglas approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉 🎉

hadia
hadia approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@Arkariang Arkariang merged commit a35a734 into master Apr 9, 2021
@Arkariang Arkariang deleted the imartin/NT-1830-braze-push-notifications-integration branch April 9, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadia hadia hadia approved these changes

@leighdouglas leighdouglas leighdouglas approved these changes

@sunday-okpoluaefe sunday-okpoluaefe Awaiting requested review from sunday-okpoluaefe

Assignees

@leighdouglas leighdouglas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arkariang @hadia @leighdouglas