Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EP-463 Android: QA 4/6 - User Properties Fixes #1203

Merged
merged 7 commits into from
Apr 13, 2021
Merged

EP-463 Android: QA 4/6 - User Properties Fixes #1203

merged 7 commits into from
Apr 13, 2021

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Apr 12, 2021 •
edited
Loading

📲 What

  • Update user_created_projects_count to be a value equal to the sum of createdProjectsCount and draftProjectsCount from the User payload
  • Update user_launched_projects_count to be a value equal to the createdProjectsCount from the User payload

🤔 Why

Segment Integration

🛠 How

  • Added the draftProjectsCount to the User struct, which is available from the api
  • Changed the above user props accordingly.

📋 QA

  • Login to the app with an account that has a value for both createdProjectsCount, draftProjectsCount, and starredProjectsCount
  • Fire any event
  • user_created_projects_count prop should be equal to createdProjectsCount and draftProjectsCount
  • user_launched_projects_count prop should only be equal to createdProjectsCount

Screen Shot 2021-04-12 at 12 33 27 PM

Story 📖

EP-463: Android QA 4/6 - User Properties Fixes

Arkariang
Arkariang approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great work here @leighdouglas

@leighdouglas leighdouglas merged commit 0a2c72c into master Apr 13, 2021
@leighdouglas leighdouglas deleted the leigh/EP-463-fix-user-props branch April 13, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkariang Arkariang Arkariang approved these changes

@hadia hadia Awaiting requested review from hadia

@sunday-okpoluaefe sunday-okpoluaefe Awaiting requested review from sunday-okpoluaefe

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leighdouglas @Arkariang