Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-489: Android QA CTA Clicked (add_ons_continue) Phase 1 #1209

Merged
merged 7 commits into from
Apr 19, 2021

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Apr 16, 2021

📲 What

Added three properties to the add_ons_continue CTA click event that were not previously being sent:

checkout_add_ons_count_total
checkout_add_ons_count_unique
checkout_add_ons_minimum_usd 

🤔 Why

Segment integration/QA feedback

🛠 How

Added functionality to the pledgeProperties method in the AnalyticEventsUtils.kt class that sets the three properties listed above.

👀 See

This is the button that triggers the event:
Screenshot_1618601420

📋 QA

  • Select a project that has add-ons (I used Deck of Dynamic Dungeons)
  • Select "Back this project"
  • Select a reward
  • Add add-ons to and press "Continue with X add-ons"
  • In segment, you should see these three properties:

Screen Shot 2021-04-16 at 3 13 10 PM

Story 📖

EP-489: Android QA CTA Clicked (add_ons_continue) Phase 1

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@leighdouglas leighdouglas merged commit 2d7dac2 into master Apr 19, 2021
@leighdouglas leighdouglas deleted the leigh/ep-489-addons-qa branch April 19, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants