NT-1867: eliminate unnecessary identify calls #1227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
TrackingClient.kt
internal variablesconfig
andloggedInUser
those two properties have become class properties onTrackingClientType.kt
LakeTrackingClient.kt
overrides it's ownconfig
andloggedInUser
SegmentTrackingClient.kt
overrides it's ownconfig
andloggedInUser
SegmentTrackingClient.kt
we update the current user only when some of the traits has change with methodupdateUserAndCheckTraits
isInitialized
state for Segment SDK👀 See
📋 QA
identify
it's not calledidentify
it's calledidentify
is calledidentify
is calledStory 📖
NT-1867