Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1867: eliminate unnecessary identify calls #1227

Merged

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Removed from TrackingClient.kt internal variables config and loggedInUser those two properties have become class properties on TrackingClientType.kt
  • LakeTrackingClient.kt overrides it's own config and loggedInUser
  • SegmentTrackingClient.kt overrides it's own config and loggedInUser
  • For SegmentTrackingClient.kt we update the current user only when some of the traits has change with method updateUserAndCheckTraits
  • Avoid race condition for initializing Segment SDK, call initialize only when we have configuration available
  • Added isInitialized state for Segment SDK
  • Modified several tests

👀 See

  • No visible changes on this PR. It's all around behaviour.

📋 QA

  • Make sure when you come from background identify it's not called
  • Make sure if you change some of your Opt-in preferences identify it's called
  • Make sure if you change your password or email you are logged out of the app and no identify is called
  • Make sure every time you log in identify is called
  • Race condition has been solved, all the events should get to Segment Dashboard

Story 📖

NT-1867

@Arkariang Arkariang requested review from sunday-okpoluaefe, hadia and leighdouglas and removed request for sunday-okpoluaefe and hadia April 28, 2021 16:15
@Arkariang Arkariang requested a review from hadia April 28, 2021 17:12
@leighdouglas leighdouglas self-assigned this Apr 28, 2021
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefect👌👌

@Arkariang Arkariang merged commit 30908d2 into master Apr 28, 2021
@Arkariang Arkariang deleted the imartin/NT-1867-eliminate-unnecessary-Identify-calls branch April 28, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants