Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1863 && NT-1860: Update translations #1231

Merged
merged 6 commits into from
May 3, 2021
Merged

Conversation

Arkariang
Copy link
Contributor

📲 What

  • New strings for the Notifications Preferences Screen
  • New Strings for the Newsletters Preferences Screen

👀 See

Screen Shot 2021-04-30 at 3 03 35 PM

Translations

| | |

📋 QA

Story 📖

NT-1860
NT-1863

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1231 (970d1ee) into master (159dd01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1231   +/-   ##
=========================================
  Coverage     74.63%   74.63%           
  Complexity      733      733           
=========================================
  Files           221      221           
  Lines          6664     6664           
  Branches        402      402           
=========================================
  Hits           4974     4974           
  Misses         1557     1557           
  Partials        133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159dd01...970d1ee. Read the comment docs.

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Arkariang Arkariang merged commit 9834dd8 into master May 3, 2021
@Arkariang Arkariang deleted the imartin/NT-1863-NT-1860 branch May 3, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants