EP-513-4: Remove Datalake Events And Worker #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…starter/android-oss into sunday-ep-523-remove-datalake-evens
This reverts commit 77e2fa2. # Conflicts: # app/src/main/java/com/kickstarter/libs/KoalaContext.kt
…starter/android-oss into sunday-ep-523-remove-datalake-evens
…starter/android-oss into sunday-ep-523-remove-datalake-evens
…ens' into sunday-ep-523-remove-datalake-evens # Conflicts: # app/src/main/java/com/kickstarter/libs/AnalyticEvents.kt # app/src/main/java/com/kickstarter/libs/KoalaContext.kt # app/src/main/java/com/kickstarter/ui/activities/ProfileActivity.kt # app/src/main/java/com/kickstarter/viewmodels/MessageThreadsViewModel.java # app/src/test/java/com/kickstarter/viewmodels/MessageThreadsViewModelTest.java
…datalake-evens # Conflicts: # app/src/main/java/com/kickstarter/ApplicationModule.java
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
============================================
+ Coverage 74.71% 74.83% +0.11%
- Complexity 734 738 +4
============================================
Files 221 221
Lines 6684 6640 -44
Branches 402 402
============================================
- Hits 4994 4969 -25
+ Misses 1557 1538 -19
Partials 133 133
Continue to review full report at Codecov.
|
…starter/android-oss into sunday-ep-523-remove-datalake-evens
…starter/android-oss into sunday-ep-523-remove-datalake-evens
Arkariang
reviewed
May 7, 2021
| @@ -25,11 +25,11 @@ | |||
| private final PublishSubject<ActivityResult> activityResult = PublishSubject.create(); | |||
| private final PublishSubject<Bundle> arguments = PublishSubject.create(); | |||
| protected final PublishSubject<Boolean> isExpanded = PublishSubject.create(); | |||
| protected final AnalyticEvents lake; | |||
| protected final AnalyticEvents analyticEvents; | |||
There was a problem hiding this comment.
Thank you for the re-naming 👍
Arkariang
reviewed
May 7, 2021
| @@ -335,15 +339,16 @@ private void displayNotificationFromUpdateActivity(final @NonNull PushNotificati | |||
| return taskStackBuilder.getPendingIntent(envelope.signature(), PendingIntent.FLAG_UPDATE_CURRENT); | |||
| } | |||
|
|
|||
| private @NonNull PendingIntent messageThreadIntent(final @NonNull PushNotificationEnvelope envelope, | |||
| @VisibleForTesting | |||
Arkariang
approved these changes
May 7, 2021
There was a problem hiding this comment.
Just two small comments left. Apart from that amazing job on this guys @sunday-okpoluaefe @hadia 👏 🎆 🚀
| lakeTrackingClient.eventNames.subscribe(lakeTest) | ||
| return lakeTrackingClient | ||
| } | ||
| // private fun lakeTrackingClient(mockCurrentConfig: MockCurrentConfig, experimentsClientType: MockExperimentsClientType): MockTrackingClient { |
| import org.junit.Test | ||
|
|
||
| class PushNotificationsTest : KSRobolectricTestCase() { | ||
| private val application: Application = ApplicationProvider.getApplicationContext() |
There was a problem hiding this comment.
KSRobolectricTestCase has a protected method application() to fetch the context Application, take a look at SegmentTest.kt:73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Android: Remove Datalake Events And Worker
🤔 Why
🛠 How
Removed LakeTrackingClient from the application
Remove LAKE from the TrackingClientType
Removed KoalaEvent enum and the affecting functions from the app
Removed All unused functions from the AnalyticsEvents class
Removed Any additional references to the DataLake are removed from the app
Removed LakeWorker needs to be removed
Deleted the provider for the Lake worker, and the provider for the retrofit service from the AppModule
Updated Tests to reflect the removed changes
👀 See
Trello, screenshots, external resources?
📋 QA
Instructions for anyone to be able to QA this work.
Story 📖
https://kickstarter.atlassian.net/browse/EP-513
https://kickstarter.atlassian.net/browse/EP-514