NT-1916: Feature flag comment threading #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
=========================================
Coverage 74.79% 74.79%
Complexity 734 734
=========================================
Files 221 221
Lines 6682 6682
Branches 403 403
=========================================
Hits 4998 4998
Misses 1551 1551
Partials 133 133 Continue to review full report at Codecov.
|
| @@ -665,6 +670,10 @@ class ProjectActivity : | |||
| startActivityWithTransition(intent, R.anim.slide_in_right, R.anim.fade_out_slide_out_left) | |||
| } | |||
|
|
|||
| private fun startCommentsThreadedActivity(projectAndData: Pair<Project, ProjectData>) { | |||
| // TODO: Start the new activity defined in https://kickstarter.atlassian.net/browse/NT-1920 | |||
There was a problem hiding this comment.
@leighdouglas you can start the new activity in this method, for the task https://kickstarter.atlassian.net/browse/NT-1920
There was a problem hiding this comment.
Got it! will do as soon as this lands and will update my PR
| @@ -1069,6 +1082,9 @@ interface ProjectViewModel { | |||
| @NonNull | |||
| override fun startCommentsActivity(): Observable<Pair<Project, ProjectData>> = this.startCommentsActivity | |||
|
|
|||
| @NonNull | |||
| override fun startCommentsThreadedActivity(): Observable<Pair<Project, ProjectData>> = this.startCommentsThreadedActivity | |||
There was a problem hiding this comment.
Nit: I think to keep parity with iOS, we are eventually going to name the comments activity RootCommentsActivity, so you may want to change the name of this method from threaded to root
📲 What
"session_app_release_version_number" = 2131version (2.13.1) in numbers,"session_app_release_version_code" = BuildConfig.VERSION_CODE🤔 Why
👀 See
| | |
📋 QA
Story 📖
NT-1916