-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NT-1918: Create GraphQL Query & Fragments #1245
NT-1918: Create GraphQL Query & Fragments #1245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
=========================================
Coverage 74.79% 74.79%
Complexity 734 734
=========================================
Files 221 221
Lines 6682 6682
Branches 403 403
=========================================
Hits 4998 4998
Misses 1551 1551
Partials 133 133 Continue to review full report at Codecov.
|
…ay-nt-1918-graphql-query-fragment
…ckstarter/android-oss into sunday-nt-1918-graphql-query-fragment
cursor | ||
node { | ||
authorBadges | ||
...comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with those fragments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As QA I executed the query on https://staging.kickstarter.com/graphiql and the result of it is the list of comments and the collaborators. Not sure though why we need the collaborators, but if that is also in the acceptance criteria for this ticket disregard my comment and I'll approve it :).
You've done a great work here @sunday-okpoluaefe
QA -> You can execute this query directly on https://staging.kickstarter.com/graphiql
query {
project(slug: "nimble-salon-quality-nails-from-the-comfort-of-your-home") {
collaborators {
edges {
node {
id
name
}
}
}
comments {
edges {
cursor
node {
authorBadges
...comment
replies {
edges {
cursor
node {
...comment
}
}
pageInfo {
...pageInfo
}
totalCount
}
}
}
pageInfo {
...pageInfo
}
totalCount
}
}
}
fragment user on User {
name
id
imageUrl(blur: false, width: 54),
isCreator
}
fragment pageInfo on PageInfo {
hasPreviousPage
hasNextPage
startCursor
endCursor
}
fragment comment on Comment {
id
author {
...user
}
body
deleted
parentId
createdAt
}
thanks. For the collaborators, I just feel there will be need to have list of participants in the comment. However, I can remove them for now. |
📲 What
Create GraphQL Query & Fragments
🤔 Why
Loads the first 25 Comments
Graph QL Query and Fragments are created
🛠 How
👀 See
Trello, screenshots, external resources?
📋 QA
QA -> You can execute this query directly on https://staging.kickstarter.com/graphiql
Story 📖
https://kickstarter.atlassian.net/browse/NT-1918