-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NT-1924; Create GraphQL Comment Data Models #1246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
============================================
- Coverage 74.79% 74.76% -0.04%
- Complexity 734 740 +6
============================================
Files 221 222 +1
Lines 6682 6697 +15
Branches 403 411 +8
============================================
+ Hits 4998 5007 +9
- Misses 1551 1552 +1
- Partials 133 138 +5
Continue to review full report at Codecov.
|
Hey @sunday-okpoluaefe ! as it is a draft I'm not sure if I should review it yet but a few comments, feel free to disregard them if you are currently working on this points :).
|
sure thanks |
…arter/android-oss into sunday-nt-1924-comment-data-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested
final CommentThread other = (CommentThread) obj; | ||
equals = Objects.equals(this.id(), other.id()) && | ||
Objects.equals(this.author(), other.author()) && | ||
Objects.equals(this.parentId(), other.parentId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add all the fields for the Model the next ones are missing
String body();
DateTime createdAt();
Boolean deleted();
String cursor();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
…ay-nt-1924-comment-data-model
…arter/android-oss into sunday-nt-1924-comment-data-model
📲 What
Create GraphQL Comment Data Models
🤔 Why
Comment models are created for the Graph QL network calls
🛠 How
CommentThread
classclass CommentThreadTest : TestCase() {
}
👀 See
Trello, screenshots, external resources?
📋 QA
Instructions for anyone to be able to QA this work.
Story 📖
https://kickstarter.atlassian.net/browse/NT-1924