NT-1908:UI for Comment Composer #1251
Conversation
hadia
requested review from
Arkariang,
jgsamudio,
leighdouglas and
sunday-okpoluaefe
| import com.kickstarter.libs.transformations.CircleTransformation | ||
| import com.squareup.picasso.Picasso | ||
|
|
||
| class CommentComposerView @JvmOverloads constructor( |
There was a problem hiding this comment.
awesome work @hadia ! 💯
| intent() | ||
| .map { it.getParcelableExtra(IntentKey.PROJECT_DATA) as ProjectData? } | ||
| .ofType(ProjectData::class.java) | ||
| .filter { it.project().isBacking || ProjectUtils.userIsCreator(it.project(), it.user()) } |
There was a problem hiding this comment.
nit: project().isBacking || ProjectUtils.userIsCreator(it.project(), it.user() could be extracted to a function it's used in lunes 62, 66 and 96
app/build.gradle
Outdated
| @@ -227,6 +227,7 @@ android { | |||
|
|
|||
| buildFeatures { | |||
| viewBinding true | |||
| dataBinding true | |||
| @@ -870,4 +870,43 @@ | |||
| <item name="android:windowIsTranslucent">true</item> | |||
| <item name="android:windowAnimationStyle">@android:style/Animation</item> | |||
| </style> | |||
|
|
|||
| <style name="CommentsTextInputLayout" parent="Widget.Design.TextInputLayout"> | |||
There was a problem hiding this comment.
Everyting looks fantastic!
Just a small things,
1- the keyboard seems to flow a bit over the composer
2- I do not see the code for the 9000 chars limit
But in my opinion this is perfect and can me merged without any problem as soon as CI passes :) in case you wanna have smaller jira tickets to tackle the previous points.
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
=========================================
Coverage 74.79% 74.79%
Complexity 740 740
=========================================
Files 222 222
Lines 6706 6706
Branches 412 412
=========================================
Hits 5016 5016
Misses 1552 1552
Partials 138 138 Continue to review full report at Codecov.
|
📲 What
Implement the following UI for the Comment Composer
🤔 Why
Add comment composer to new comments activity
🛠 How
👀 See
https://www.loom.com/share/43179a365389447d9f2f5caab75c58f6
📋 QA
Test open project comments /updates on statging
Story 📖
https://kickstarter.atlassian.net/browse/NT-1908