NT-1907:UI for Comment Card #1255

hadia · 2021-05-21T18:37:43Z

📲 What

A reusable component has been created to render a single comment

🤔 Why

Build new comment UI

🛠 How

Creat card view for comments with test
Create view holder and adapter with unit test
Bind to Recycler view with a call from the server

👀 See

device-2021-05-21-203700.mp4

📋 QA

open comment list from any project

Story 📖

https://kickstarter.atlassian.net/browse/NT-1907

codecov · 2021-05-21T19:17:35Z

Codecov Report

Merging #1255 (735a394) into master (a38f215) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1255   +/-   ##
=========================================
  Coverage     74.50%   74.50%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6632     6632           
  Branches        404      404           
=========================================
  Hits           4941     4941           
  Misses         1555     1555           
  Partials        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38f215...735a394. Read the comment docs.

Arkariang · 2021-05-21T22:38:30Z

app/src/main/java/com/kickstarter/ui/adapters/CommentsAdapter.kt

+
+    fun takeData(comments: List<Comment>) {
+        sections().clear()
+        addSection(Observable.from(comments).toList().toBlocking().single())


Not fan of blocking observables,
usually on the adapter for creating a section we do that on the init Block, take a look here

android-oss/app/src/main/java/com/kickstarter/ui/adapters/ActivityFeedAdapter.kt

Line 161 in a38f215

insertSection(SECTION_LOGGED_IN_EMPTY_VIEW, emptyList<Any>())

or here

android-oss/app/src/main/java/com/kickstarter/ui/adapters/ProfileAdapter.kt

Line 23 in a38f215

insertSection(SECTION_EMPTY_VIEW, emptyList<Any>())

Remove part of handling empty state as app crash in case loggout user and it will be handle in different ticket

Arkariang · 2021-05-21T22:46:36Z

app/src/main/java/com/kickstarter/ui/views/CommentCard.kt

+
+    fun setAvatarUrl(url: String?) {
+        url?.let {
+            Picasso.get().load(it)


This is a picky comment for the future, I would like to not speak directly to a dependency, this comment is more meant for future tech debt as I know this concrete case with picasso is quite extended throwout the app so no need to act on it.
But we should create or a utils class or a client to inject on the UI layer that will isolate us from calling any third party directly

we can also create an extension layer or Custom Imageview using through app

totally agree

Arkariang · 2021-05-21T22:49:19Z

app/src/main/java/com/kickstarter/ui/views/CommentCard.kt

+import com.kickstarter.ui.extensions.parseHtmlTag
+import com.squareup.picasso.Picasso
+
+class CommentCard @JvmOverloads constructor(


☺️☺️🎉

Arkariang · 2021-05-21T22:51:20Z

app/src/main/java/com/kickstarter/viewmodels/CommentsViewModel.kt

@@ -25,18 +28,22 @@ interface CommentsViewModel {
        fun currentUserAvatar(): Observable<String?>
        fun enableCommentComposer(): Observable<Boolean>
        fun showCommentComposer(): Observable<Void>
+        fun commentsList(): Observable<List<Comment>?>


Does it needs to be optional? in case of no comments we could have an empty list so no null allowed on this Observable

Arkariang · 2021-05-21T22:54:20Z

app/src/main/res/layout/item_comment_card.xml

+    android:focusable="true"
+    android:orientation="vertical">
+
+    <com.kickstarter.ui.views.CommentCard


☺️☺️🎉

Arkariang · 2021-05-21T22:59:01Z

app/src/test/java/com/kickstarter/ui/view/CommentCardTest.kt

+import org.junit.Before
+import org.junit.Test
+
+class CommentCardTest : KSRobolectricTestCase() {


AWESOME!!! 💞

☺️☺️🎉

Arkariang

I left a minor comment on the CommentsAdapter. Apart from that you've done an exceptional work here @hadia , Love it!

Arkariang · 2021-05-21T23:06:42Z

Tested it on my environment

… and it will be handle in different ticket

hadia · 2021-05-24T18:50:58Z

@Arkariang @leighdouglas @sunday-okpoluaefe @jgsamudio

Remove part of handling empty state as app crash in case logout user and it will be handle in different ticket

https://kickstarter.atlassian.net/browse/NT-1943

This reverts commit 4bb11b5.

hadia added 3 commits May 21, 2021 17:54

Add comment card view

9bcd832

Add test to comment card view holder

efe915e

Add activity test to bind comments scroll

14268b8

hadia requested review from Arkariang, leighdouglas and sunday-okpoluaefe May 21, 2021 18:37

hadia added 3 commits May 21, 2021 20:59

Merge branch 'master' into comment_card

3736951

fix files format

7477665

Merge remote-tracking branch 'origin/comment_card' into comment_card

5e12df0

Arkariang reviewed May 21, 2021

View reviewed changes

Merge branch 'master' into comment_card

0f2643f

Arkariang reviewed May 21, 2021

View reviewed changes

Arkariang approved these changes May 21, 2021

View reviewed changes

hadia added 4 commits May 24, 2021 15:31

fix comment adapter comment

2b8f7d7

Create Image view extensions to bind url

3f5f6db

Fix image ext Format

9e789e4

Remove part of handling empty state as app crash in case loggout user…

735a394

… and it will be handle in different ticket

hadia requested a review from jgsamudio May 24, 2021 18:50

hadia merged commit 4bb11b5 into master May 24, 2021

hadia deleted the comment_card branch May 24, 2021 19:05

hadia added a commit that referenced this pull request May 24, 2021

Revert "NT-1907:UI for Comment Card (#1255)"

02f7c32

This reverts commit 4bb11b5.

hadia restored the comment_card branch May 24, 2021 19:46

hadia deleted the comment_card branch May 24, 2021 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NT-1907:UI for Comment Card #1255

NT-1907:UI for Comment Card #1255

hadia commented May 21, 2021

codecov bot commented May 21, 2021 •

edited

Arkariang May 21, 2021

hadia May 24, 2021

Arkariang May 21, 2021

hadia May 21, 2021

Arkariang May 21, 2021

hadia May 24, 2021

Arkariang May 21, 2021

hadia May 24, 2021

Arkariang May 21, 2021

hadia May 24, 2021

Arkariang May 21, 2021

hadia May 24, 2021

Arkariang May 21, 2021

hadia May 24, 2021

Arkariang left a comment

Arkariang commented May 21, 2021

hadia commented May 24, 2021 •

edited

NT-1907:UI for Comment Card #1255

NT-1907:UI for Comment Card #1255

Conversation

hadia commented May 21, 2021

📲 What

🤔 Why

🛠 How

👀 See

📋 QA

Story 📖

codecov bot commented May 21, 2021 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arkariang left a comment

Choose a reason for hiding this comment

Arkariang commented May 21, 2021

hadia commented May 24, 2021 • edited

codecov bot commented May 21, 2021 •

edited

hadia commented May 24, 2021 •

edited