Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1956: Thread view and navigation #1262

Merged
merged 7 commits into from May 27, 2021
Merged

NT-1956: Thread view and navigation #1262

merged 7 commits into from May 27, 2021

Conversation

Arkariang
Copy link
Contributor

馃摬 What

  • New screen for the Thread view

馃憖 See

threadActivity.mp4

| | |

馃搵 QA

  • Hit the reply button in a comment

Story 馃摉

NT-1956

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #1262 (abe221f) into master (49faa4d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1262      +/-   ##
============================================
+ Coverage     74.34%   74.36%   +0.01%     
- Complexity      739      740       +1     
============================================
  Files           221      221              
  Lines          6646     6646              
  Branches        405      405              
============================================
+ Hits           4941     4942       +1     
  Misses         1569     1569              
+ Partials        136      135       -1     
Impacted Files Coverage 螖
.../src/main/java/com/kickstarter/models/Comment.java 66.66% <0.00%> (+6.66%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 49faa4d...abe221f. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review May 27, 2021 00:02
* false: in case we just need to open the replies screen
*
* // TODO: Once the viewReplies UI is completed call this method with openKeyboard = false
* // TODO: https://kickstarter.atlassian.net/browse/NT-1955
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunday-okpoluaefe once you start working on https://kickstarter.atlassian.net/browse/NT-1955 for opening thread screen please call startThreadActivity(comment, false)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Arkariang Arkariang merged commit 4077bb5 into master May 27, 2021
@Arkariang Arkariang deleted the imartin/NT-1956 branch May 27, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants