Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO JIRA]: Updated gradle plugin #1263

Merged
merged 1 commit into from May 27, 2021
Merged

[NO JIRA]: Updated gradle plugin #1263

merged 1 commit into from May 27, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented May 27, 2021 •
edited

馃摬 What

  • Updated gradle plugin

馃 Why

  • Maintenance
  • Support new android studio versions

馃搵 QA

  • the project builds properly on your environment
  • execute on your environment succesfully the script for getting new translations : ./bin/milkrun update-strings

leighdouglas
leighdouglas approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 馃帀

@Arkariang Arkariang merged commit bf603e7 into master May 27, 2021
@Arkariang Arkariang deleted the imartin/update-gradle-plugin branch May 27, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@hadia hadia Awaiting requested review from hadia

@sunday-okpoluaefe sunday-okpoluaefe Awaiting requested review from sunday-okpoluaefe

Assignees
No one assigned
Labels
maintenance 馃棞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkariang @leighdouglas