NT-953: Fetch a thread query #1266
Conversation
- No longer need to specify the buildToolsVersion each gradle plugin now uses their own
| @@ -105,7 +105,6 @@ android.applicationVariants.all { variant -> | |||
|
|
|||
| android { | |||
| compileSdkVersion 30 | |||
| buildToolsVersion '29.0.3' | |||
There was a problem hiding this comment.
buildToolsVersion no need to be specified any more, the gradle pluging now use their own versions
| @@ -189,44 +189,6 @@ class KSApolloClient(val service: ApolloClient) : ApolloClientType { | |||
| } | |||
| } | |||
|
|
|||
| private fun createCommentObject(commentFr: fragment.Comment?): Comment { | |||
There was a problem hiding this comment.
It has been moved outside the KSApollo class as a private package method nothing more, I was perfectly able to use it for replies as well 👍
| .build() | ||
| } | ||
|
|
||
| private fun createPageInfoObject(pageFr: fragment.PageInfo?): PageInfoEnvelope { |
There was a problem hiding this comment.
It has been moved outside the class as a private package method nothing more, I was perfectly able to use it for replies as well 👍
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
============================================
- Coverage 74.36% 74.34% -0.02%
+ Complexity 740 739 -1
============================================
Files 221 221
Lines 6646 6646
Branches 405 405
============================================
- Hits 4942 4941 -1
Misses 1569 1569
- Partials 135 136 +1
Continue to review full report at Codecov.
|
|
No unit test added yet as this task was specific to create the query only and we have not specified any output yet, once the |
| @@ -36,6 +36,8 @@ interface ApolloClientType { | |||
|
|
|||
| fun getProjectComments(slug: String, cursor: String?, limit: Int = 25): Observable<CommentEnvelope> | |||
|
|
|||
| fun getRepliesForComment(comment: Comment, cursor: String = "", pageSize: Int = 25): Observable<CommentEnvelope> | |||
There was a problem hiding this comment.
Great job @Arkariang . Just tiny comment; can we rename pageSize to limit or limit to pageSize for consistency?. Otherwise looks good
There was a problem hiding this comment.
We have const on my brach for page size we can use it after merge
There was a problem hiding this comment.
I'll tackle that comment on https://kickstarter.atlassian.net/browse/NT-1969
📲 What
🤔 Why
🛠 How
replies.graphqlfile, note I'm reusing all the fragments previously created :)apolloClienthas a new methodgetRepliesForCommentthat executes previous mentioned query and retruns aCommentEnvelopeThreadViewModelthere is a subscription already working that fetches replies, for now it just displays on logcat the retrieved data👀 See
it matches the comments on the web
You can also take a look on the networking profiler
| | |📋 QA
Story 📖
NT-1953