-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NT-1955: UI β Comment Card with threads #1267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1267 +/- ##
=========================================
Coverage 74.34% 74.34%
Complexity 739 739
=========================================
Files 221 221
Lines 6646 6646
Branches 405 405
=========================================
Hits 4941 4941
Misses 1569 1569
Partials 136 136 Continue to review full report at Codecov.
|
β¦rter/android-oss into sunday-nt-1955-ui-comment-thread
app/src/main/java/com/kickstarter/ui/viewholders/CommentCardViewHolder.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The reply button works like a charm
- But for the Replies UI I do strongly think no need to have a new component please @sunday-okpoluaefe let me know if there is any concern around it or if I'm missing some context here
app/src/main/java/com/kickstarter/viewmodels/CommentsViewHolderViewModel.kt
Show resolved
Hide resolved
@@ -101,6 +119,13 @@ | |||
android:visibility="gone" | |||
app:constraint_referenced_ids="reply_button,flag_button" /> | |||
|
|||
<androidx.constraintlayout.widget.Group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @sunday-okpoluaefe !
β¦ay-nt-1955-ui-comment-thread # Conflicts: # app/src/main/java/com/kickstarter/ui/views/CommentCard.kt # app/src/main/java/com/kickstarter/viewmodels/CommentsViewHolderViewModel.kt
- added one missing state
β¦tin/NT-1984-feature-flags * 'master' of github.com:kickstarter/android-oss: NT-1955: UI β Comment Card with threads (#1267)
π² What
UI β Comment Card with threads
π€ Why
π How
π See
π QA
View replies
button. You should be taken to the threads screenStory π
https://kickstarter.atlassian.net/browse/NT-1955