Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1955: UI – Comment Card with threads #1267

Merged
merged 18 commits into from
Jun 2, 2021

Conversation

sunday-okpoluaefe
Copy link
Contributor

@sunday-okpoluaefe sunday-okpoluaefe commented May 30, 2021

πŸ“² What

UI – Comment Card with threads

πŸ€” Why

  • In order to support threads we need to add the missing controls to our Comment
  • Also, we need to support yet another variation of the Comment Card design, to display replies

πŸ›  How

  • Added padding end and margin guidelines to threadactivitylayout
<androidx.constraintlayout.widget.Guideline
            android:id="@+id/left_guideline"
            app:layout_constraintGuide_begin="@dimen/grid_5"
            android:orientation="vertical"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"/>


        <androidx.recyclerview.widget.RecyclerView
            android:id="@+id/comment_replies_recycler_view"
            app:layout_constraintStart_toEndOf="@id/left_guideline"
            android:layout_width="0dp"
            android:paddingEnd="@dimen/grid_3"
            android:layout_height="wrap_content"
            android:background="@color/kds_white"
            app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
            app:layout_constraintTop_toBottomOf="@id/comments_card_view"
            tools:layout_editor_absoluteX="0dp"
            tools:listitem="@layout/comment_card" />

πŸ‘€ See

Screen Shot 2021-05-30 at 12 37 55 PM

Screen Shot 2021-05-30 at 2 19 06 PM

Before πŸ› After πŸ¦‹

πŸ“‹ QA

  • Select any project. Go to comments. You should see the updated comment card
  • Click View replies button. You should be taken to the threads screen

Story πŸ“–

https://kickstarter.atlassian.net/browse/NT-1955

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #1267 (4718472) into master (1b95824) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1267   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1b95824...4718472. Read the comment docs.

@sunday-okpoluaefe sunday-okpoluaefe marked this pull request as ready for review May 31, 2021 10:21
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The reply button works like a charm
    ViewReplies
  • But for the Replies UI I do strongly think no need to have a new component please @sunday-okpoluaefe let me know if there is any concern around it or if I'm missing some context here

@@ -101,6 +119,13 @@
android:visibility="gone"
app:constraint_referenced_ids="reply_button,flag_button" />

<androidx.constraintlayout.widget.Group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sunday-okpoluaefe !

Arkariang and others added 4 commits June 2, 2021 13:01
…ay-nt-1955-ui-comment-thread

# Conflicts:
#	app/src/main/java/com/kickstarter/ui/views/CommentCard.kt
#	app/src/main/java/com/kickstarter/viewmodels/CommentsViewHolderViewModel.kt
- added one missing state
@Arkariang Arkariang merged commit d99f750 into master Jun 2, 2021
@Arkariang Arkariang deleted the sunday-nt-1955-ui-comment-thread branch June 2, 2021 22:17
Arkariang added a commit that referenced this pull request Jun 2, 2021
…tin/NT-1984-feature-flags

* 'master' of github.com:kickstarter/android-oss:
  NT-1955: UI – Comment Card with threads (#1267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants