NT-1977: UX – Not logged in / not backer for Comment Card

[leighdouglas]

📲 What

We want to disable the reply/comment card action buttons in different user states i.e. logged in or out, backing or not backing, etc.
I also renamed a few variables to be clearer and extracted some functionality into individual methods, for readability and all that good stuff 😄

🤔 Why

• The reply option should only show if the user is logged in and has backed the project, or if they are the project creator.
• A user should not be able to reply to projects if they are not logged in, or if they are logged in but have not backed the project or they are not the creator.

🛠 How

• Created a new CommentCardData model that holds the comment, the project the comment is from, and the state of the card (for future use when replying, errored, etc).
• We then transform the list of comments returned in the network call to a list of CommentCardData, which is passed to the adapter and eventually the CommentsViewHolderViewModel
• The CommentsViewHolderViewModel view model then performs a check when initialized that returns true or false depending on if the user should see the reply button. This boolean is passed to the CommentViewModel, which toggles the visibility of the action group on the comment card, which holds the reply button as well as the flag comment button.

👀 See

No reply/action buttons: Logged out and logged in and NOT backing, respectively:

Reply/Action buttons visible: Logged in and backing

📋 QA

Make sure you have a project that you are not backing, a project that you are backing, and a project that you created, and all projects must have comments. Then test the different states listed below.

⛔ = no reply or action buttons
✅ = reply and action buttons visible

These are the different states to test:
Logged out = ⛔
Logged in and not backing = ⛔
Logged in and backing = ✅
Logged in and creator = ✅

Story 📖

NT-1977: UX – Not logged in / not backer for Comment Card

[Arkariang]

Lgtm!

[codecov]

Codecov Report

Merging #1269 (57aaadd) into master (3ad9ab3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1269   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad9ab3...57aaadd. Read the comment docs.