NT-1910: UX – Not logged in / Not backer for Comment Composer

[leighdouglas]

📲 What

This change handles the different states of the comment composer in relation to the user state i.e. logged out, not backing, etc.
Also had to update the UI to make the separator disappear as it was still appearing when the composer was gone.

🤔 Why

There are three states -> ENABLED, DISABLED, GONE

• GONE -> The comment composer should be completely gone if the user is not logged in.
• ENABLED -> If the user is logged in and a backer, or is the creator, the comment composer is enabled.
• DISABLED -> If the user is logged in but not a backer, then the comment composer should be in the disabled state

🛠 How

Created an enum that holds these three states, and when the comment view model is initiated, it emits this state to the activity and the view responds accordingly.

👀 See

Logged in: Backing and not backing

Logged out:

📋 QA

Make sure you have a project that you are not backing, a project that you are backing, and a project that you created, and all projects must have comments. Test going to the comments directly from the project page, as well as from the updates page. Then test the different states listed below.

🔴 = no comment composer
🟡 = comment composer disabled
🟢 = comment composer enabled

These are the different states to test:
Logged out = 🔴
Logged in and not backing = 🟡
Logged in and backing = 🟢
Logged in and creator = 🟢

Story 📖

NT-1910: UX – Not logged in / Not backer for Comment Composer

[codecov]

Codecov Report

Merging #1271 (7b7fa6f) into master (f7c7046) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1271   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c7046...7b7fa6f. Read the comment docs.

[Arkariang]

It looks great @leighdouglas !

• Small request that can be handle in another ticket as it was not already there, but waht you think about adding tests for the composer component? we can use as example the CommentCardTest https://github.com/kickstarter/android-oss/blob/master/app/src/test/java/com/kickstarter/ui/view/CommentCardTest.kt

[leighdouglas]

@Arkariang I noticed that too and figured we could update in a subsequent ticket. I'll make a ticket for it :)