Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2044: UI – Handle long translations for fail to post error message #1289

Merged

Conversation

sunday-okpoluaefe
Copy link
Contributor

@sunday-okpoluaefe sunday-okpoluaefe commented Jun 14, 2021

📲 What

UI – Handle long translations for fail to post error message.

🤔 Why

  • To make sure error message can spread across two lines

  • Icon should be aligned with the first line

🛠 How

  • Created separate views to hold icon and message
  • Created view group to hold visibility
  • Added group click listeners to icon and mesage

👀 See

| Before 🐛 |
Screenshot_20210611-092337_Kickstarter

|After 🦋 |
error

📋 QA

  • Change device language to Spanish/Argentinean
  • Select any backed project
  • Go to comments
  • Disable network connection
  • Post a comment

Story 📖

https://kickstarter.atlassian.net/browse/NT-2044

@sunday-okpoluaefe sunday-okpoluaefe requested review from hadia, leighdouglas and Arkariang and removed request for hadia and leighdouglas June 14, 2021 10:48
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1289 (1c549ec) into master (a5648a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1289   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
  Complexity      739      739           
=========================================
  Files           221      221           
  Lines          6646     6646           
  Branches        405      405           
=========================================
  Hits           4941     4941           
  Misses         1569     1569           
  Partials        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5648a9...1c549ec. Read the comment docs.

@sunday-okpoluaefe sunday-okpoluaefe marked this pull request as ready for review June 15, 2021 15:38
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sunday-okpoluaefe sunday-okpoluaefe merged commit 243bd5a into master Jun 15, 2021
@sunday-okpoluaefe sunday-okpoluaefe deleted the sunday-nt-2044-long-translations-for-failed-post branch June 15, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants