NT-2003:UX β Show pending comment dialog #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values/strings.xml
Arkariang
reviewed
Jul 19, 2021
| @@ -18,3 +19,41 @@ fun Context.registerActivityLifecycleCallbacks(callbacks: Application.ActivityLi | |||
| this.registerActivityLifecycleCallbacks(callbacks) | |||
| } | |||
| } | |||
|
|
|||
| fun Context.showAlertDialog( | |||
β¦g' into hadia/Show_pending_comment_dialog
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
=========================================
Coverage 74.12% 74.12%
Complexity 739 739
=========================================
Files 221 221
Lines 6666 6666
Branches 406 406
=========================================
Hits 4941 4941
Misses 1589 1589
Partials 136 136 Continue to review full report at Codecov.
|
Arkariang
added a commit
that referenced
this pull request
Jul 19, 2021
β¦tin/NT-2125-first-test * 'master' of github.com:kickstarter/android-oss: - Removed sharedUserId property NT-2003:UX β Show pending comment dialog (#1329) NT-1996 :UI/UX β Error loading thread (#1328) NT-2093: Skip first emitted value from paginated data to avoid initially showing empty state showing on root comments screen (#1323) NT-2124: Shot 5.11.0 library integration (#1324) # Conflicts: # app/build.gradle # app/src/androidTest/java/com/kickstarter/screenshoot/testing/di/AndroidTestApplicationModule.kt # app/src/androidTest/java/com/kickstarter/screenshoot/testing/ui/components/CommentCardShotTest.kt # app/src/internalDebug/AndroidManifest.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
Show pending comment dialog
π€ Why
Add confirmation dialog when users have a failed post or something written in the comment composer and try to
π How
Create alert Dialog
Check if have pending comments in case of back and pull to refresh
π See
device-2021-07-19-202828.mp4
π QA
Story π
https://kickstarter.atlassian.net/browse/NT-2003