NT-2001:UX β Show pending reply dialog #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values/strings.xml
β¦g' into hadia/Show_pending_comment_dialog
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
=========================================
Coverage 74.12% 74.12%
Complexity 739 739
=========================================
Files 221 221
Lines 6666 6666
Branches 406 406
=========================================
Hits 4941 4941
Misses 1589 1589
Partials 136 136 Continue to review full report at Codecov.
|
app/src/main/java/com/kickstarter/ui/activities/ThreadActivity.kt
Outdated
Show resolved
Hide resolved
Arkariang
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
Show pending comment dialog in replies thread activity
π€ Why
Add confirmation dialog when users have a failed post or something written in the comment composer in reply thread and try to Go back to root comments
π How
Checking if there are pending replies handling back action with dialog
π See
device-2021-07-19-215435.mp4
π QA
add pending reply try back action submit reply and then try back again
Story π
https://kickstarter.atlassian.net/browse/NT-2001