Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1965:UX – Show not-a-backer-anymore comments #1334

Merged
merged 9 commits into from
Jul 27, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Jul 23, 2021

πŸ“² What

Comments from users who have cancelled their pledge should be hidden at first.

πŸ€” Why

To mark the canceled pledge users comments

πŸ›  How

  • Add flagged to cancled pledge

  • image

  • Add new status to Comment card

  • image

  • Handle new UI for Show canceled comment

  • Handle on show comment in comment and thread activity

  • Handle Root comment and pass status to thread Activity

πŸ‘€ See

device-2021-07-23-211604.mp4

πŸ“‹ QA

Check Project "Keep Moms in the Game "

Story πŸ“–

https://kickstarter.atlassian.net/browse/NT-1965

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1334 (09c1f6f) into master (a35cf9b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1334      +/-   ##
============================================
- Coverage     74.19%   74.18%   -0.02%     
  Complexity      743      743              
============================================
  Files           221      221              
  Lines          6666     6667       +1     
  Branches        406      407       +1     
============================================
  Hits           4946     4946              
  Misses         1584     1584              
- Partials        136      137       +1     
Impacted Files Coverage Ξ”
.../src/main/java/com/kickstarter/models/Comment.java 56.25% <0.00%> (-3.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a35cf9b...09c1f6f. Read the comment docs.

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! πŸŽ‰

@hadia hadia merged commit ded1315 into master Jul 27, 2021
@hadia hadia deleted the hadia/Show-not-a-backer-anymore-comments branch July 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants